Add a 12-hour clock option for displayed times#2105
Open
frankrousseau wants to merge 1 commit into
Open
Conversation
Add an opt-in user preference to render clock times with AM/PM instead of the 24-hour format. The flag is stored in the person record generic data field, so it follows the user across browsers without any backend change, and is saved through the existing profile save path. Comment timestamps, news feed times and entity chat times honour it via the new formatTimeOfDay helper. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problems
Solutions
dataJSONB field through the existing profile save path, so it follows the user across browsers with no Zou schema changeformatTimeOfDayhelper insrc/lib/time.js(plus aformatTimewrapper in theuseTimecomposable) and use it in Comment, NewsRow and EntityChatDays, with unit tests covering 24h/12h, midnight and noon