[players] Pre-seek next decoder to handle-in to avoid slate flash#2104
Open
frankrousseau wants to merge 1 commit into
Open
[players] Pre-seek next decoder to handle-in to avoid slate flash#2104frankrousseau wants to merge 1 commit into
frankrousseau wants to merge 1 commit into
Conversation
With handles set on a playlist, the hidden decoder preloading the next entity sat at t=0 until playNext seeked it at switch time, so the first frame (the slate) was painted for an instant before the seek completed. Park the preloaded decoder on the next entity's handle-in frame as soon as it is preloaded (loadEntity, switchPlayers, and on nextHandleIn prop updates), fed by a new nextEntityHandleIn computed in PlaylistPlayer. Fixes cgwire#1019 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problems
playNextat switch time, so the newly-current decoder painted frame 0 until that async seek completedSolutions
loadEntityandswitchPlayers), so frame 0 is never the frame presented when the players swapMultiVideoViewerwith a newnextHandleInprop, computed inPlaylistPlayerfrom the next entity's own handle data (handles can differ per entity), and re-apply the pre-seek when the prop updates after a switchloadEntityand re-parks on handle changes