Skip to content

Refactor select step impl to behave consistently between iterative and recursive programs. #1958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactor select step impl to behave consistently between iterative and recursive programs. #1958

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions eval/compiler/flat_expr_builder.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -976,14 +976,14 @@ class FlatExprVisitor : public cel::AstVisitor {
return;
}

StringValue field = cel::StringValue(select_expr.field());
if (auto depth = RecursionEligible(); depth.has_value()) {
auto deps = ExtractRecursiveDependencies();
if (deps.size() != 1) {
SetProgressStatusIfError(absl::InternalError(
"unexpected number of dependencies for select operation."));
return;
}
StringValue field = cel::StringValue(select_expr.field());

SetRecursiveStep(
CreateDirectSelectStep(std::move(deps[0]), std::move(field),
Expand All @@ -994,9 +994,9 @@ class FlatExprVisitor : public cel::AstVisitor {
return;
}

AddStep(CreateSelectStep(select_expr, expr.id(),
options_.enable_empty_wrapper_null_unboxing,
enable_optional_types_));
AddStep(CreateSelectStep(
std::move(field), select_expr.test_only(), expr.id(),
options_.enable_empty_wrapper_null_unboxing, enable_optional_types_));
}

// Call node handler group.
Expand Down
Loading
Loading