fix(react): serialize local storage seed initialization - #407
Open
Egge21M wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: d687d30 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Egge21M
marked this pull request as ready for review
July 31, 2026 17:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
localStorageSeedGetter()initialized a missing seed with a non-atomic localStorage read-generate-write sequence. Concurrent first-run tabs could each cache a different seed even though only the last seed written remained recoverable from storage.Summary
Verification
bun run --filter='@cashu/coco-react' test(50 tests passed)bun run --filter='@cashu/coco-react' typecheckbun run --filter='@cashu/coco-react' lint(passes with two existing warnings)bun run --filter='@cashu/coco-react' buildbunx prettier --check packages/react/src/lib/utils/localStorageSeedGetter.ts packages/react/src/lib/utils/localStorageSeedGetter.test.ts packages/react/README.md .changeset/lock-local-storage-seeds.mdThis issue was found by Project Loupe