Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## hurlimann-estimator #1554 +/- ##
====================================================
Coverage 94.46% 94.46%
====================================================
Files 100 100
Lines 6307 6307
Branches 803 803
====================================================
Hits 5958 5958
Misses 225 225
Partials 124 124
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Pyright Type CompletenessView the full Project (full
Other symbols referenced but not exported by
Symbols without documentation:
Patch (exported symbols added or changed by this PR): no exported symbol type-completeness changes detected. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 381fd8d. Configure here.
| "# The paper prints whole numbers or five decimals; tolerance for comparing against its tables.\n", | ||
| "def close(actual, printed, atol):\n", | ||
| " assert np.allclose(actual, printed, atol=atol), (np.round(actual, 5), printed)" | ||
| ] |
There was a problem hiding this comment.
Verification helper uses default rtol
Medium Severity
close calls np.allclose with only atol, so the default rtol=1e-5 is still applied. For the large whole-number totals in Tables 7.8 and 7.9 that intended tolerance of 1 becomes tens or hundreds of units, so the notebook can accept values that do not match the paper’s rounding.
Reviewed by Cursor Bugbot for commit 381fd8d. Configure here.


Summary of Changes
Adds notebook to verify that the
HurlimannCLRestimator, introduced in #1553, reproduces the values in the paper.Related GitHub Issue(s)
#1502
AI/LLM Usage
Claude Opus 5.5
Additional Context for Reviewers
Submitter's Checklist
[FIX],[FEAT],[DOCS],[TST],[CHORE], or[BRK]).Reviewer's Checklist
Note
Low Risk
Documentation-only notebook with assertions against published examples; does not modify reserving logic or runtime behavior.
Overview
Adds
docs/user_guide/hurlimann_verification.ipynb, a user-guide notebook that checkscl.HurlimannCLRagainst the numeric tables in Hürlimann (Astin Bulletin 39(1)), for issue #1502.The notebook rebuilds the paper’s paid triangles (incremental and cumulative), runs the five credibility
methodvariants with exposure viasample_weight, andasserts outputs against published values for parameters (p_,m_,credibility_), IBNR/ultimates, and MSE ratios. Where the CAS Exam 7 errata fixes misprinted ultimates/MSE columns, the expected values use the corrected tables. For Table 7.12 (A.M. Best comparison), it documents that exposures are least-squares reconstructed because the paper omits them, and still checks all method factors to three decimals.Low documentation-only change; no library API or estimator behavior changes.
Reviewed by Cursor Bugbot for commit 381fd8d. Bugbot is set up for automated code reviews on this repo. Configure here.