Repository navigation
Conversation
Contributor
|
There are already lots of similar tests for emojize() mainly in the file tests/test_core.py |
Author
Thank you for the clarification! I reviewed the existing tests in test_core.py and I see that the coverage for emojize() is already comprehensive. To avoid redundancy, I’ll go ahead and close this PR. I appreciate your time and feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new test file
test_emojize.pywith parameterized unit tests for theemojize()function. The goal is to improve test coverage and ensure consistent emoji conversion for typical input cases.All tests pass successfully using
pytest, and the structure aligns with the project's testing conventions.This is my first open source contribution, and I'm excited to learn from the community. Feedback is warmly welcome!