Skip to content

feat: codify CVE policy#570

Open
mr-cal wants to merge 4 commits into
mainfrom
work/cve-policy
Open

feat: codify CVE policy#570
mr-cal wants to merge 4 commits into
mainfrom
work/cve-policy

Conversation

@mr-cal

@mr-cal mr-cal commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

Codifies our policy for handling CVEs in direct and transitive dependencies.


  • I've followed the contribution guidelines.
  • I've signed the CLA.
  • I've successfully run make lint && make test.
  • I've added or updated any relevant documentation.
  • In documents I changed, I added a meta description if one was missing.
  • I've updated the relevant release notes.

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Copilot AI review requested due to automatic review settings June 24, 2026 17:58
@mr-cal mr-cal requested a review from bepri as a code owner June 24, 2026 17:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Codifies guidance for handling CVEs via comments in pyproject.toml, clarifying how applications vs libraries should manage vulnerable direct and transitive dependencies when using dependency-groups and uv constraints.

Changes:

  • Adds policy guidance for CVEs in [dependency-groups].
  • Expands guidance for CVE avoidance in [tool.uv].constraint-dependencies.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pyproject.toml Outdated
Comment thread pyproject.toml Outdated

@bepri bepri left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this sufficiently explains the policy. As I understand it, libraries should just do what we've been doing (bump the lockfile and move on with our lives), while applications should also:

  • Pin direct dependencies in project.dependencies
  • Pin optional dependencies in dependency-groups
  • Pin indirect dependencies in uv.tool.constraint-dependencies

Comment thread pyproject.toml Outdated
@mr-cal

mr-cal commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator Author

As I understand it, libraries should just do what we've been doing (bump the lockfile and move on with our lives)

I thought that the agreement was to use constraint-dependencies in libraries to reduce exposure to having vulnerable builds in the CI jobs for that library?

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@bepri

bepri commented Jun 24, 2026

Copy link
Copy Markdown
Member

I thought that the agreement was to use constraint-dependencies in libraries to reduce exposure to having vulnerable builds in the CI jobs for that library?

I don't recall that point, I mostly remembered Tiago mentioning that it gives a false sense of security since uv doesn't consider constraint-dependencies of dependencies when building a project. But with that in mind, yeah, I agree with you.

Comment thread pyproject.toml Outdated
@bepri bepri requested a review from tigarmo June 24, 2026 19:11
@mr-cal

mr-cal commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator Author

I don't recall that point, I mostly remembered Tiago mentioning that it gives a false sense of security since uv doesn't consider constraint-dependencies of dependencies when building a project. But with that in mind, yeah, I agree with you.

I'm going to summon @lengau as well, as I think that was his idea. I think it would only affect the minimum-version CI job.

@mr-cal mr-cal requested a review from lengau June 24, 2026 19:13
mr-cal added 2 commits June 24, 2026 14:13
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants