Skip to content

DOCPR-1799 fix for adding support limitation#16

Open
shaloo wants to merge 3 commits into
canonical:mainfrom
shaloo:shaloo/fix-docpr-1799
Open

DOCPR-1799 fix for adding support limitation#16
shaloo wants to merge 3 commits into
canonical:mainfrom
shaloo:shaloo/fix-docpr-1799

Conversation

@shaloo

@shaloo shaloo commented Jun 19, 2026

Copy link
Copy Markdown
Contributor
  • Have you updated CHANGELOG.md with relevant non-documentation file changes?
  • Have you updated the documentation for this change?

@shaloo
shaloo force-pushed the shaloo/fix-docpr-1799 branch from 1635ea2 to 012ee3e Compare June 19, 2026 16:29
@shaloo
shaloo marked this pull request as draft June 19, 2026 16:34
@shaloo
shaloo force-pushed the shaloo/fix-docpr-1799 branch 3 times, most recently from 373a90d to 047dd74 Compare June 19, 2026 16:43
@jahn-junior

Copy link
Copy Markdown
Collaborator

The spell check failure is caused by a bug that came about when we incorporated sphinx-llm. I'm bringing in the patch fix from the sphinx-stack repo with #17.

@shaloo
shaloo marked this pull request as ready for review June 26, 2026 09:54
@shaloo
shaloo marked this pull request as draft June 26, 2026 09:54
@shaloo
shaloo marked this pull request as ready for review July 1, 2026 08:59
@shaloo
shaloo marked this pull request as draft July 1, 2026 08:59
@shaloo

shaloo commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

@jahn-junior would you know by when you'll be able to bring in the patch fix here for the spell check failure resolution?

@SecondSkoll

Copy link
Copy Markdown
Collaborator

If you rebase this now @shaloo it should pass.

@shaloo
shaloo marked this pull request as ready for review July 3, 2026 17:03
@shaloo
shaloo marked this pull request as draft July 3, 2026 17:10
@shaloo
shaloo marked this pull request as ready for review July 6, 2026 16:42

@a-velasco a-velasco left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the bonus whitespace cleanup :)

Comment thread docs/how-to/configure-your-project.rst Outdated

If any additional extensions need specific Python packages, ensure they are installed alongside the other requirements by adding them to the ``docs/requirements.txt`` file.

The Sphinx Stack fully supports only the third-party extensions included in the Starter pack. Support is limited for extensions you add or customize in requirements.txt

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest phrasing it a bit more explicitly to avoid confusion between Sphinx Stack/Starter pack.

Suggested change
The Sphinx Stack fully supports only the third-party extensions included in the Starter pack. Support is limited for extensions you add or customize in requirements.txt
The only third-party extensions the Sphinx Stack fully supports are those included via the [canonical-sphinx extension bundle](https://github.com/canonical/canonical-sphinx).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jahn-junior thank you for this improvement. Is it okay if I add the expectation-setting boundary as shown below?

The only third-party extensions the Sphinx Stack fully supports are those included in the [canonical-sphinx extension bundle](https://github.com/canonical/canonical-sphinx). Support is limited for any additional or customized extensions added via requirements.txt.

@jahn-junior jahn-junior Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To clarify what I meant in my last review, I'd like as little emphasis on canonical-sphinx as possible. It clashes with how we treat canonical-sphinx these days—strictly as a theme—and will be outdated with the release of Ulwazi. The only reason we still set up extensions in canonical-sphinx is for backward-compatibility.

When it comes to the extensions we support, users should look to the default requirements.txt file.

I suggest something like:

The only extensions formally supported by the Sphinx Stack are those included in its default requirements.txt file. If you add any extensions to this list, it's your responsibility to ensure that they're compatible with the rest of the Sphinx Stack.

@jahn-junior jahn-junior left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The added text doesn't quite reflect our supported extensions. We do support all of the extensions listed in the Sphinx Stack requirements.txt file. Because canonical-sphinx is included in this file, we do also support the extensions it sets up.

However, we do not recommend using the optional full dependency group, and this change could be interpreted as though we do. So, I think for simplicity's sake, we should just say that we only fully support the extensions listed in the default requirements.txt file. Since canonical-sphinx is getting deprecated soon, this is also more future-proof.

Co-authored-by: Andreia <andreia.velasco@canonical.com>
@shaloo
shaloo requested review from a-velasco and jahn-junior July 15, 2026 09:47
Comment on lines 123 to +126
If your project requires additional extensions beyond the default list, add the
extension list to the new project in ``docs/requirements.txt``.

The legacy Sphinx Stack fully supports only the third-party extensions included in the Starter pack. Support is limited for extensions you add or customize in requirements.txt

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If your project requires additional extensions beyond the default list, add the
extension list to the new project in ``docs/requirements.txt``.
The legacy Sphinx Stack fully supports only the third-party extensions included in the Starter pack. Support is limited for extensions you add or customize in requirements.txt
The Sphinx Stack supports a reasonable set of default extensions. If your project requires additional extensions, add them to the project's ``docs/requirements.txt`` file.
It's your responsibility to ensure that extensions you add to this list are compatible with
the rest of the Sphinx Stack.

Mirroring my other suggestion. Also updated the preceding sentence to make this flow a little better.

Comment thread docs/how-to/configure-your-project.rst Outdated

If any additional extensions need specific Python packages, ensure they are installed alongside the other requirements by adding them to the ``docs/requirements.txt`` file.

The Sphinx Stack fully supports only the third-party extensions included in the Starter pack. Support is limited for extensions you add or customize in requirements.txt

@jahn-junior jahn-junior Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To clarify what I meant in my last review, I'd like as little emphasis on canonical-sphinx as possible. It clashes with how we treat canonical-sphinx these days—strictly as a theme—and will be outdated with the release of Ulwazi. The only reason we still set up extensions in canonical-sphinx is for backward-compatibility.

When it comes to the extensions we support, users should look to the default requirements.txt file.

I suggest something like:

The only extensions formally supported by the Sphinx Stack are those included in its default requirements.txt file. If you add any extensions to this list, it's your responsibility to ensure that they're compatible with the rest of the Sphinx Stack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants