Skip to content

internal/rest/resources/control: retry remaining join addresses on client connect err #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
claudiubelu wants to merge 1 commit into
base: v4
Choose a base branch
from
Draft

internal/rest/resources/control: retry remaining join addresses on client connect err #760

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion internal/rest/resources/control.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,9 @@ func joinWithToken(state types.State, r *http.Request, req *types.Control) (*typ

client, err := state.Connect().Member(&url.URL, false, cert)
if err != nil {
return nil, nil, err
logger.Warn("Failed to get client for cluster member", slog.String("address", url.String()), slog.String("error", err.Error()))

@roosterfish roosterfish Jun 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect we currently simply return the error as the call to shared.GetRemoteCertificate should have already failed if it's not reachable.

Would you mind sharing a reproducer how to trigger this?

@roosterfish roosterfish Jul 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@claudiubelu any update on this?

@roosterfish roosterfish Jul 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking as draft until you get a chance to get back to it @claudiubelu.

lastErr = err
continue
Comment on lines 248 to +252
}

joinInfo, err = internalClient.AddClusterMember(context.Background(), client, newClusterMember)
Expand Down