fix(remote-build): ignore dangling symlinks#1104
Open
bepri wants to merge 4 commits into
Open
Conversation
bepri
commented
Jun 25, 2026
|
|
||
|
|
||
| @pytest.fixture(autouse=True) | ||
| @pytest.fixture |
Member
Author
There was a problem hiding this comment.
Every test that needed this mock was already directly requesting it, but the autouse broke my new test
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes remote-build failing when the project directory contains dangling symlinks by adjusting how the remote-build worktree repository is created, and documenting the fix.
Changes:
- Update
WorkTree.init_repo()to avoid crashing during repository copy when dangling symlinks are present. - Adjust unit tests around worktree initialization and add coverage for dangling-symlink scenarios.
- Add a changelog entry for the remote-build symlink handling fix.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
craft_application/remote/worktree.py |
Changes how the project tree is copied into the remote-build worktree repo. |
tests/unit/remote/test_worktree.py |
Updates fixtures and adds a dangling-symlink unit test for worktree init. |
docs/reference/changelog.rst |
Documents the remote-build dangling-symlink behavior change in the changelog. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lengau
approved these changes
Jun 25, 2026
Member
Author
|
Duplicate of #1100 |
4 tasks
mr-cal
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make lint && make test?docs/reference/changelog.rst)?Fixes #1103.