-
Notifications
You must be signed in to change notification settings - Fork 61
feat: support bin packages parsing #299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
upils
wants to merge
35
commits into
canonical:main
Choose a base branch
from
upils:bin-slices
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
df532f7
feat: support bin packages parsing
upils f3a58a6
fix: correct style fix
upils daf5a71
fix: lint
upils 633b0e1
ci: rerun
upils 6fd3d1c
fix: fully qualified slice names
upils b68da53
style: rename to avoid confusion
upils 8494876
fix: start renaming to realname
upils 510d4cd
fix: more renaming/refactoring
upils 2eb88e0
fix: more renaming
upils 74ee585
fix: improve name displayed
upils 3cab6a3
fix: refine naming
upils d86b9f9
fix: add missing check on format
upils 1cda0ff
fix: remove pkgDefaultPrefix
upils 267c6a3
fix: consistent use of pkg.RealName
upils 619e0ec
fix: more name tweaking
upils 952e929
fix: correct involontary lint fixes
upils fb4d6e5
fix: revert accidental linting fixes
upils ffc5aaf
style: harmonize names
upils d214000
feat: revert approach
upils 8e8aef0
refactor: more cleaning
upils e7357d3
fix: review
upils 27e2709
fix: ensure store is defined when parsing
upils 6d19749
fix: properly fill returned pkgs when searching
upils 824c002
style: lint
upils 7358c94
fix: filter store pkgs out of the selection for now
upils be67dbd
fix: check store kind is known
upils 22050d4
fix: use bin value for kind in tests
upils 2e69156
style: add missing period
upils ed9e923
fix: review
upils 65771cb
tests: integrate v3 tests to common table
upils d929e92
fix: check store kind when slices used
upils 867fcff
docs: clarify reason for temp arch filling
upils 33fc4ca
fix: apply review comments
upils c2be41a
fx: clearly fail if store packages are found for now
upils a816047
fix: remove wrong field
upils File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Note to reviewer]: Before the package parsing we only have the real name. So this check can now only be done after the package parsing because we need the package name.