Skip to content

feat(release-review-pr): add findings-collector checklist item #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hdamker wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(release-review-pr): add findings-collector checklist item #429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions release_automation/templates/pr_bodies/release_review_pr.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ _The following actions and checks are done by a Release Management reviewer befo
- [ ] Breaking changes are documented and version updates follow SemVer rules
- [ ] Mandatory release assets are present for each API according to its status
- [ ] All remaining validation warnings are documented in issues and the reasons for deferral are defensible
- [ ] Content findings needing a `main` PR are collected as sub-issues of one issue titled `Release {{release_tag}} review findings` (see [Recording review findings](https://github.com/camaraproject/ReleaseManagement/blob/main/documentation/readiness/api-readiness-checklist.md#recording-review-findings))

<details>
<summary><b>Required release assets per API status</b></summary>
Expand Down
1 change: 1 addition & 0 deletions release_automation/tests/test_template_loader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ def test_render_release_review_pr_template(self):
assert "Commonalities r3.4" in result
assert "Mandatory release assets are present for each API according to its status" in result
assert "All remaining validation warnings are documented in issues and the reasons for deferral are defensible" in result
assert "Content findings needing a `main` PR are collected as sub-issues of one issue titled `Release r4.1 review findings`" in result
assert "Assign the Release Management reviewer(s) as assignee(s) of this PR" in result
assert "The following actions and checks are done by a Release Management reviewer before approving the PR" in result
assert "### Valid next actions for codeowners" in result
Expand Down