idDocument description improvement - #91
Open
PedroDiez wants to merge 1 commit into
Open
Conversation
CAMARA Validation — PASS0 errors, 0 warnings, 1 hints | Profile: standard |
KevScarr
approved these changes
Aug 24, 2026
KevScarr
left a comment
KevScarr
left a comment
There was a problem hiding this comment.
LGTM as we can't define a pattern or format for the idDocument.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
This PR adds
idDocumentdefinition ininfo.descriptionidDocumentdefinition to the "Relevant Definitions and concepts" section ofinfo.description, explaining it's an identity-document number used as an alternative/complementary identifier tophoneNumber.Background comes from Release Management review of first Customer Insights release Candidate for Sync26
Which issue(s) this PR fixes:
Fixes #88
Special notes for reviewers:
Changelog input
Additional documentation
This section can be blank.