Skip to content

Remove fisher(), which never returned a p-value - #36

Merged
zhiaos merged 1 commit into
masterfrom
drop-fisher
Aug 10, 2026
Merged

Remove fisher(), which never returned a p-value#36
zhiaos merged 1 commit into
masterfrom
drop-fisher

Conversation

@zhiaos

@zhiaos zhiaos commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Addresses #30. Not closing it yet — leaving that to @iblacksand, who confirmed the method was abandoned in favour of stouffer.

fisher() returned a chi-square density on 2^(k-1) degrees of freedom rather than an upper-tail probability on 2k. The two defects compound into an inversion: three p-values of 0.999 combined to 0.0015, five to 7.7e-21. Details and the measured table are in #30.

Removes the function, the MetaAnalysisMethod::Fisher variant and its two match arms. Removal rather than repair follows @iblacksand's note on the issue: nothing calls it — webgestaltpy uses stouffer, and WebGestaltR asked Rust for "fisher" but overwrote the result with poolr::stouffer — so a corrected implementation would have no users, while a wrong one is a trap for anyone who later removes the "redundant" R computation.

The Continuous import went with it; it was only needed for the .pdf() call.

Breaking for anyone matching on MetaAnalysisMethod, which now has a single variant. Worth a 0.4.0 rather than 0.3.3 whenever this is published — the seed field added in #31 is breaking for struct-literal construction of GSEAConfig for the same reason.

WebGestaltR is updated in a companion PR so its bridge no longer names Fisher; that lands first, so nothing breaks on the next re-vendor.

cargo test --all passes (5 tests), and cargo vendor still resolves cleanly — the check #34 exists to remind us about.

@zhiaos
zhiaos merged commit a80787f into master Aug 10, 2026
1 check passed
@zhiaos
zhiaos deleted the drop-fisher branch August 10, 2026 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant