Remove fisher(), which never returned a p-value - #36
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #30. Not closing it yet — leaving that to @iblacksand, who confirmed the method was abandoned in favour of
stouffer.fisher()returned a chi-square density on2^(k-1)degrees of freedom rather than an upper-tail probability on2k. The two defects compound into an inversion: three p-values of 0.999 combined to 0.0015, five to 7.7e-21. Details and the measured table are in #30.Removes the function, the
MetaAnalysisMethod::Fishervariant and its two match arms. Removal rather than repair follows @iblacksand's note on the issue: nothing calls it —webgestaltpyusesstouffer, andWebGestaltRasked Rust for"fisher"but overwrote the result withpoolr::stouffer— so a corrected implementation would have no users, while a wrong one is a trap for anyone who later removes the "redundant" R computation.The
Continuousimport went with it; it was only needed for the.pdf()call.Breaking for anyone matching on
MetaAnalysisMethod, which now has a single variant. Worth a 0.4.0 rather than 0.3.3 whenever this is published — the seed field added in #31 is breaking for struct-literal construction ofGSEAConfigfor the same reason.WebGestaltRis updated in a companion PR so its bridge no longer names Fisher; that lands first, so nothing breaks on the next re-vendor.cargo test --allpasses (5 tests), andcargo vendorstill resolves cleanly — the check #34 exists to remind us about.