fix: use btcutil.DecodeAddress for Bitcoin address validation#129
Open
vwinee21 wants to merge 1 commit into
Open
fix: use btcutil.DecodeAddress for Bitcoin address validation#129vwinee21 wants to merge 1 commit into
vwinee21 wants to merge 1 commit into
Conversation
Replace fragile prefix matching with proper btcutil.DecodeAddress validation which includes checksum verification. Resolves TODO in IsBitcoinAddressForNetwork.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace fragile prefix matching in
IsBitcoinAddressForNetworkwith properbtcutil.DecodeAddressvalidation which includes checksum verification.The previous implementation used simple string prefix matching which could pass invalid addresses (e.g. an address starting with 'bc1' but with invalid checksum).
btcutil.DecodeAddressperforms full validation against the network'schaincfg.Params.Network.Params()already exists in thebtcnetworkpackage and returns the correct*chaincfg.Paramsfor each network, making this a clean one-liner replacement.Resolves the TODO comment in
IsBitcoinAddressForNetwork.Public
Replace prefix-based Bitcoin address checking with
btcutil.DecodeAddressfor proper validation including checksum verification.