Enable release pipeline for v... branches#3964
Conversation
DrJosh9000
force-pushed
the
enable-release-pipeline-for-v-branches
branch
from
407ed14 to
1e9f0f9
Compare
|
@buildsworth-bk review |
![buildsworth-bk-app[bot]](https://avatars.githubusercontent.com/in/3010600?s=60&v=4){kind=small}
There was a problem hiding this comment.
Read the diff end-to-end and parsed the YAML before and after to confirm the reformat is a no-op — the only semantic changes are the two called out in the description: e2e-tests added to upload-release-steps.depends_on (no other deps removed, just re-sorted alphabetically) and |v\d+ appended to the branch regex. Both line up with the intent. The new key matches the existing key: e2e-tests step, and \d / $$ are escaped the way Buildkite expects.
Would otherwise approve, but there's no risk: label on the PR.
Want to dig deeper? The full session log is attached to this Buildkite build. Download the session file and open a new pi session with it:
Download the buildsworth logs from build 332, then answer my questions about the findings.
|
@buildsworth-bk approve |
|
@buildsworth-bk review |
There was a problem hiding this comment.
Bulk of the diff is a YAML indent reformat (verified equivalent against the parsed structure). The three real changes — re-sorting upload-release-steps.depends_on, adding e2e-tests (key exists at line 274), and extending the branch regex with v\d+ — all match the description. Downstream release triggers in upload-release-steps.sh remain gated by DRY_RUN, version metadata, and the tag-existence check, so a bad merge here is cheap to revert and won't ship anything unintended.
Want to dig deeper? The full session log is attached to this Buildkite build. Download the session file and open a new pi session with it:
Download the buildsworth logs from build 337, then answer my questions about the findings.
1 participant
Description
When a
v...branch changes, create the release steps.Context
Prep for v4 (actually for v3 oldstable, because v4 already has this change)
Changes
v\d+Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go tool gofumpt -extra -w .)Disclosures / Credits
I did not use AI tools at all