Tracking leftover overlay/filter work after #2227 (Base UI popover, select, dialog on search + settings).
#2227 shipped the overlay layer and used it on the surfaces that were hurting. These follow-ups are the rest of the homemade menus and the next search-filter step. Look stays in @releases/design-system; overlay behavior stays in web/src/components/ui. Do not grow the design-system package into an in-house Radix.
Done
Remaining
Not this
Leave these homemade. They are product/chrome UI, not missing overlay primitives:
- Lightbox (
lightbox.tsx) — media viewer with paging
- Mobile nav (
mobile-nav.tsx) — one header caller, not a Sheet
- Range navigator brush/timeline — product viz; nested quick-ranges can ride Select when that file is next edited
- Native
<select> (changelog file picker, fetch-plan priority, workspace invitations)
- Link tabs (
SourceTabs, org filter tabs) — routing, not Base UI Tabs
- DS Toggle / ThemeToggle / buttons / inputs — look, already in
@releases/design-system
Add a child issue per item when it starts, rather than stuffing implementation notes here.
Tracking leftover overlay/filter work after #2227 (Base UI popover, select, dialog on search + settings).
#2227 shipped the overlay layer and used it on the surfaces that were hurting. These follow-ups are the rest of the homemade menus and the next search-filter step. Look stays in
@releases/design-system; overlay behavior stays inweb/src/components/ui. Do not grow the design-system package into an in-house Radix.Done
web/src/components/ui)ReleaseFilterInput+ collection timeline filters on PopoverinputClasscopies onto DS / auth-flow constantspackages/design-system/README.md: no newpointerdown+ Escape menusRemaining
pointerdown+ Escape copy in each):web/src/components/open-in-agent-menu.tsxweb/src/components/release-admin-menu.tsxweb/src/components/source-admin-menu.tsxweb/src/components/collection-admin-menu.tsxweb/src/components/report-issue.tsxweb/src/components/account-nav.tsx(header account menu)web/src/components/account-settings-nav.tsx(workspace selector)web/src/components/org/agent-copy-button.tsx(split-button Copy for agent)web/src/components/hover-card.tsxwith Base UI PreviewCard or Tooltip (pick one, not both). Callers:date-tooltip,info-tooltip,importance-marker,cadence-chrome,org-table,range-navigator. Do not growhover-card.tsx.ReleaseFilterInput.SourceWorkflowDrawer(homemade right-hand overlay) when that file is next touched.auth-flow.tsx) still has a slightly taller/rounder button + input than settings DS. Unify only if we want one action language site-wide.Not this
Leave these homemade. They are product/chrome UI, not missing overlay primitives:
lightbox.tsx) — media viewer with pagingmobile-nav.tsx) — one header caller, not a Sheet<select>(changelog file picker, fetch-plan priority, workspace invitations)SourceTabs, org filter tabs) — routing, not Base UI Tabs@releases/design-systemAdd a child issue per item when it starts, rather than stuffing implementation notes here.