Skip to content

[Deployment] UnknownClient - v0.0.0 - 2026-09-10 #356

Open

Description

@soroush5

Running helm_deploy_v2/uninstall.py against a release that does not exist prints:

An error occurred while running Helm: ...
Uninstallation of <name> completed successfully.

even though nothing was uninstalled. Real failures are masked the same way.

Cause: run_helm_command() catches subprocess.CalledProcessError and never re-raises, so the except block in uninstall() (including the intended release: not found ... Skipping... path) is unreachable dead code. Additionally, "release: not found" in str(e) could never match helm's stderr, since str(CalledProcessError) only contains the command and exit status.

Repro: stub subprocess.run to raise CalledProcessError with helm's release: not found output and call uninstall() — before the fix it prints success and exits 0.

Activity

  1. changed the title [-]uninstall.py reports failed helm uninstall as 'completed successfully'[/-] [+][Deployment] UnknownClient - v0.0.0 - 2026-09-10[/+] on Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions