Export normals correctly - #211
Draft
gmorenz wants to merge 2 commits into
Draft
Conversation
gmorenz
marked this pull request as draft
June 9, 2025 03:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on top of #210
Unfortunately I don't currently have an easy way to test this code - only the corresponding code in anvil (paramatrix-dev/anvil#15)... so while it's probably correct I don't feel confident in asking for it to be merged. In the very near future I'll set up something so I can render meshes from this library as well as anvil at which point I'll move the PR from a draft to a real one (and maybe try and fix up line 93 at the same time... since that looks very suspicious... particularly the part where the only use of
normal_arrayisnormal_array.Length()).