Added custom fixture to fix session merge issue#9
Open
UjjawalShakya wants to merge 3 commits intobrowserstack:mainfrom
Open
Added custom fixture to fix session merge issue#9UjjawalShakya wants to merge 3 commits intobrowserstack:mainfrom
UjjawalShakya wants to merge 3 commits intobrowserstack:mainfrom
Conversation
07souravkunda
requested changes
Mar 4, 2025
|
|
||
|
|
||
| def test_bstack_sample(page) -> None: | ||
| def test_sample(session_capabilities) -> None: |
Collaborator
There was a problem hiding this comment.
same change for local test as well
conftest.py
Outdated
| result = page.evaluate("() => {}", browser_stack_command) | ||
| return json.loads(result) | ||
|
|
||
| if os.environ.get('REMOTE', 'true') == "true": |
Collaborator
There was a problem hiding this comment.
this condition not needed
conftest.py
Outdated
| def session_capabilities(playwright: Playwright): | ||
| global timenow | ||
| global lock | ||
| test_name = os.environ.get('PYTEST_CURRENT_TEST').split(' ')[0].split('::')[1] |
Collaborator
There was a problem hiding this comment.
doesn't this create duplicate tests at browserstack. Please attach sessions
Author
There was a problem hiding this comment.
07souravkunda
approved these changes
Mar 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.