Repository navigation
fix: satisfy ty 0.0.87 checks and bump pinned floor - #716
Merged
Merged
Conversation
- Narrowed Literal/required-session envelope overrides are intended pydantic discriminators; scope ty ignores per site with rationale. - track_async takes Sequence (covariant) instead of invariant list. - contextmanager helpers annotate Generator, not Iterator. - Bump dev ty floor 0.0.73 -> 0.0.87 to match CI's uvx resolution.
brndnmtthws
marked this pull request as ready for review
October 14, 2026 14:22
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
ty checkCI failures seen on PR branches: CI resolvesuvx tyto 0.0.87 while the repo pinnedty>=0.0.73, and the newer checker flags 7 errors plus 2 deprecation warnings onmain.User Impact
CI
ty checkpasses again on all branches. No runtime behavior changes; annotations and dependency floor only.Root Cause
tyfloor (0.0.73) lagged CI's floatinguvx ty(0.0.87), which addedinvalid-mutable-overrideandinvalid-argument-type(invariance) diagnostics pluscontextmanagerreturn-type deprecations.track_asynctook invariantlist[Coroutine]while callers pass concrete coroutine lists.@contextmanagerhelpers annotatedIteratorinstead ofGenerator.Fix
log.track_async: parameter widened toSequence[Coroutine[...]](covariant; all callers pass lists).db.session_scope,ibkr.supervise_order_errors: returnGeneratorper ty's prescribed fix.Literal/as_of_sessionenvelope narrowings intail_harvest_decision.py/target_weight_policy.py: intentional pydantic discriminators (validated at construction, schema-exported, never mutated via base) — scopedty: ignore[invalid-mutable-override]per site with rationale.tyfloor to>=0.0.87and refreshuv.lockso local checks match CI.Validation
uvx ty check(0.0.87): cleanuv run ty check: cleanuv run ruff check .,uv run ruff format --check .: cleanuv run pytest: 818 passed