support additional cloudsql machine types - #30
Open
Jeff McCollum (jeffmccollum) wants to merge 3 commits into
Open
Jeff McCollum (jeffmccollum) wants to merge 3 commits into
Jeff McCollum (jeffmccollum) wants to merge 3 commits into
Conversation
Jeff McCollum (jeffmccollum)
marked this pull request as ready for review
September 23, 2026 14:35
Jeff McCollum (jeffmccollum)
requested review from
brianvans (brianvans) and
Alexey Soldatchenko (soldatchenko)
September 23, 2026 14:36
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: db473a2981
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Jeff McCollum (jeffmccollum)
force-pushed
the
jeff/expanded-sql-support
branch
from
September 25, 2026 14:18
db473a2 to
848ab9d
Compare
Jeff McCollum (jeffmccollum)
added this pull request to stack #32
September 25, 2026 14:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for additional cloud sql machine types now that hyperdisk for cloud sql is out of beta.
Switching from N2 to C4/C4a does incur downtime so we don't recommend changing this after deployment.
This does require updating the provider version from 6.x.x to 8.x.x