Repository navigation
fix(python): honor classifier spec option overrides - #264
Open
joo00der (jihtsan) wants to merge 1 commit into
Open
joo00der (jihtsan) wants to merge 1 commit into
joo00der (jihtsan) wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Fixes #262. Merge saved spec options with explicit kwargs before the existing single classifier constructor call, giving explicit kwargs precedence. This fixes duplicate-keyword TypeError in from_spec/from_spec_file without changing constructor validation/defaults, token clamping, prompts, cache policy or unrelated thread rendering.
Seven original-code regressions fail before repair and pass after it. Cover model/engine, use_cot=False, temperature=0, token options includingNone, saved defaults/client/render options, spec immutability and real temporary YAML loading with cache cleanup. Independent Standards/Spec reviews on434acc303ea3b95a1cef45ea9c4c13212a8fd690 have no remaining findings. This Python-only loader has no matching TypeScript API to modify.
Validation
Validated locally with Python3.13.12/uv.lock dev+scipy. Hosted CI, real-provider/model success and other runtime/platform matrices are unverified. No real keys or paid quota were used; full-suite success is not claimed. Maintainers own approval/merge/release.
AI assistance: OpenAI Codex researched, implemented and independently reviewed this change.