Skip to content

add nvidia-dual-branch image feature - #747

Merged
vigh-m merged 2 commits into
bottlerocket-os:developfrom
vigh-m:nvidia-multi-driver/twoliter
Sep 17, 2026
Merged

vigh-m merged 2 commits into
bottlerocket-os:developfrom
vigh-m:nvidia-multi-driver/twoliter

Conversation

@vigh-m

@vigh-m vigh-m commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Description of changes:

  • add nvidia-dual-branch image feature

Testing done:

  • Built and tested nvidia and non-nvidia AMIs to validate the behaviour of the feature.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@vigh-m
vigh-m force-pushed the nvidia-multi-driver/twoliter branch 2 times, most recently from aab5c48 to d484ae2 Compare September 16, 2026 18:38
@ginglis13

Copy link
Copy Markdown
Contributor

Looks like our app inventory test is incompatible with bumps to kit metadata version because it's pulling from the live kernel-kit? :

[81](https://github.com/bottlerocket-os/twoliter/actions/runs/35135680033/job/104947572680?pr=747#step:7:6482)
[2026-09-16T19:54:19Z INFO  twoliter::project::lock::image] Resolving dependency image dependency 'bottlerocket-kernel-kit-9.1.0@public.ecr.aws/bottlerocket/bottlerocket-kernel-kit:v9.1.0'.
Error: kit appears to be built with metadata version 'v3', possibly by an older version of twoliter with unsupported incompatibilities. This version of twoliter supports metadata version 'v4'.

@ginglis13
ginglis13 self-requested a review September 16, 2026 21:21
Signed-off-by: Vighnesh Maheshwari <vighmah@amazon.com>
@vigh-m
vigh-m force-pushed the nvidia-multi-driver/twoliter branch from d484ae2 to c3f93ef Compare September 17, 2026 16:02

@piyush-jena piyush-jena left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build (CI) failure is intentional and due to metadata update.

@vigh-m
vigh-m merged commit 5ad4aa5 into bottlerocket-os:develop Sep 17, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants