Support modify kernel-parameters for different arch in build image.

[pengubco]

I have a use case where I need different kernel parameters for the same variant across different architectures. For example, for the aws-dev variant, if the architecture is aarch64, I want to add "pci=realloc" and remove "quiet".

Before:

[package.metadata.build-variant]
kernel-parameters = [
    # Other parameters omitted for clarity
    "quiet",
]

After:

[package.metadata.build-variant]
kernel-parameters = [
    "pci=realloc",
]

Could Twoliter add a feature to support this? Something like:

twoliter modify-kernel-parameters --variant "aws-dev" --add "pci=realloc" --remove "quiet"

It could be even better if the modification is integrated into the "cargo make build" command. Such that there is no -dirty tag of images built.

[sam-berning]

Thanks for the feature request! We'll look into this. I think we'd probably want to encode this in the variant's Cargo.toml somehow, just to make it clear in the code what's included in the variant. One initial idea is that we could add an optional arch to the metadata path, e.g.:

[package.metadata.x86_64.build-variant]
kernel-parameters = [
    "quiet",
]

[package.metadata.aarch64.build-variant]
kernel-parameters = [
    "pci=realloc",
]

Would that suit your use case?

[pengubco]

Yes. That's an even better solution! No modification on the fly. As explicit as it can be. Thank you!