elfvis: deterministic treemap layout#1
Open
marciogranzotto wants to merge 1 commit into
Open
Conversation
HashMap iteration order in cluster_unknown_children is randomized, so clusters with equal total size could appear in different order across runs. Add name as a secondary sort key to guarantee a stable, reproducible layout. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Makes treemap layout deterministic by ensuring child nodes are sorted with a stable, total ordering when sizes are equal.
Changes:
- Adds a secondary sort key (name) when child sizes compare equal.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Release Note
Treemap visualization is now fully deterministic — running elfvis multiple times on the same ELF file always produces the same layout.
What Changed (Technical)
In
src/tree.rs, the children sort (finalize_sizes) now uses name as a secondary key when sizes are equal:b.size.cmp(&a.size).then_with(|| a.name.cmp(&b.name)). This makes the sort fully deterministic regardless of HashMap iteration order.What Needs Testing
Known Issues and Limitations
None.
Security Analysis
No security-sensitive changes.