Open
Conversation
🦋 Changeset detectedLatest commit: f751c52 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
natemoo-re
reviewed
Apr 15, 2026
| this.#message = msg; | ||
| } | ||
|
|
||
| this.state = 'cancel'; |
Member
There was a problem hiding this comment.
Should we do this.state = 'submit' when the exitCode === 0? Currently this would treat every exit as cancel.
natemoo-re
reviewed
Apr 15, 2026
dreyfus92
approved these changes
Apr 27, 2026
Collaborator
Author
|
@dreyfus92 @natemoo-re FYI this is blocked because it has brought the ol' windows bug back. we still haven't figured out how to fix that bug properly in main. the proposed fix in main introduces the other windows bug. so this branch has pretty much the same issues until i can figure out the right solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This reworks the spinner to be based on the
Promptclass and have acoreprompt like the others do.It should solve a few rendering bugs/inconsistencies.
DRAFT until i have chance to fix tests up