SHOP-8855: PHP 8.5 compatibility updates - #183
Open
deepsidhu1313 wants to merge 5 commits into
Open
Conversation
…ls:: equivalents \GuzzleHttp\json_encode() and \GuzzleHttp\json_decode() were deprecated in Guzzle 7 and removed in later versions. Use \GuzzleHttp\Utils::jsonEncode() and \GuzzleHttp\Utils::jsonDecode() instead.
deepsidhu1313
changed the title
YaphBlaster
approved these changes
Jun 23, 2026
ReflectionProperty::setAccessible() has had no effect since PHP 8.1 —
getValue()/setValue() work on private and protected properties without
it — and PHP 8.5 deprecates the call outright:
Deprecated: Method ReflectionProperty::setAccessible() is
deprecated since 8.5, as it has no effect since PHP 8.1
unserializeModel() calls it once per property per model, so this was by
far the loudest deprecation in a consuming app's logs: a single admin
page load in product-bundles emitted dozens of these lines, drowning
actual errors in the Apache log.
Removing the call is behaviour-neutral on any supported version.
Verified against product-bundles on PHP 8.5: full unit suite green
(123 tests, 186 assertions), and a direct unserializeModel() of a
Product with private $id/$title still hydrates correctly.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SHOP-8855: PHP 8.5 Compatibility Updates
Summary
Updates bold-shopify-toolkit for PHP 8.5 compatibility.
PHP 8.5 Deprecation Fixes
Implicit Nullable Parameters
Base::serializeModel()—$entityparamDeprecated Guzzle Functions
Client::post()—\GuzzleHttp\json_encode()→\GuzzleHttp\Utils::jsonEncode()Client::put()—\GuzzleHttp\json_encode()→\GuzzleHttp\Utils::jsonEncode()Client::sendRequestToShopify()—\GuzzleHttp\json_decode()→\GuzzleHttp\Utils::jsonDecode()These functions were deprecated in Guzzle 7 and removed in later versions.
Beta Release
8.0.0-beta.4— available for testing