chore: pre-announcement cleanup — stale README claims, license, security policy - #24
Merged
Merged
Conversation
- regenerate the gas table from GasBench at the pinned block (propose 138,778 / castVote 135,842; queue and execute unchanged) - validateProposal signature: the hook receives the governor-computed proposalId first; the layout row carried descriptionHash from the pre-proposalId interface - self-cancel: 'always' was false — cancel is barred in the propose block; document the bar and why it exists - layout table: add RulesetQuorumFraction, the batch and voteNonce suites, and the FeeOnTransferToken mock; retitle the page Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Source files already carried MIT SPDX headers with no license text at the root. SECURITY.md gives researchers a private disclosure path (shared@blockful.io) ahead of the external audit. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
No+Slash predates the option's final name; also reword one bond-suite pin comment that referenced an internal review id. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
BOND_AMOUNT (1,000 ENS, EP 5.15) and VETO_THRESHOLD (500k ENS) were quoted in the README but existed nowhere in src; ENSParams is the single source of truth, so they live here. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Internal-process wiring, and it triggered on a branch that is being retired. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes surfaced by a pre-announcement review of the repo, ahead of the implementation report going to the ENS forum.
README corrections
GasBenchat the pinned block 25,445,220: propose is 138,778 (was 139,441) and castVote is 135,842 (was 135,831); queue, execute, and all live-governor numbers were already correct.validateProposalsignature: the hook receives the governor-computedproposalIdas its first parameter; the prose and the layout row still described the pre-refactor(validator): pass the governor-computed proposalId through IProposalValidator #20 interface (descriptionHash)._validateCancelbars any cancel in the propose block. Now documented, including why the bar exists (kills the atomic propose→cancel bond round-trip).src/RulesetQuorumFraction.sol, the batch and voteNonce test suites, and theFeeOnTransferTokenmock; page title now matches the project name.New files
Code comments and params
No+Slash→AgainstAndSlashinRulesetCountingnatspec and its test suite (the option's shipped name).ENSParamsgainsBOND_AMOUNTandVETO_THRESHOLD— both were quoted in the README but existed nowhere insrc/.No behavior changes:
srcdiffs are comments and two new constants. Full unit suite (309 tests) and the fork gas bench pass locally.🤖 Generated with Claude Code