chore(dashboard): comment the Shutter DAO out of the DAO list - #2138
chore(dashboard): comment the Shutter DAO out of the DAO list#2138brunod-e wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
🚅 Deployed to the anticapture-pr-2138 environment in anticapture-infra
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4472ff2d20
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| SCR = "SCR", | ||
| OBOL = "OBOL", | ||
| SHU = "SHU", | ||
| // SHU = "SHU", |
There was a problem hiding this comment.
Remove Shutter from config-backed discovery surfaces
Commenting out this enum member makes every /shu route fail toDaoIdEnum, but Shutter remains registered in shared/dao-config/index.ts. Consequently, app/sitemap.ts and app/llms.txt/route.ts, which enumerate Object.keys(daoConfigByDaoId), still publish /shu and its proposal URLs even though those URLs now return 404. Remove the config registration as well, or make these discovery surfaces enumerate enabled DAOs.
Useful? React with 👍 / 👎.
|
🔍 Vercel preview: https://anticapture-6f2ud1igj-ful.vercel.app |
🎨 UI Review
This is a narrow, well-executed change — the Sitemap &
|
# Conflicts: # apps/dashboard/features/create-proposal/constants.ts
Comments
SHUout ofDaoIdEnum(same move as the commented-outOPTIMISM), which removes Shutter fromALL_DAOSand everywhere the app enumerates DAOs: the panel table, routing (/shunow 404s), the shutter.gov.blockful.io hostname mapping, sitemap/OG surfaces.Fallout handled
Unlike OP, Shutter had live
DaoIdEnum.SHUreferences, disabled minimally and revertibly:create-proposal/constants.ts— SHU line commented out ofcanCreateProposalForDao.submitProposalRequest.ts—isAzoriusDaoreturnsfalse(SHU was the only Azorius DAO); the Azorius submit path stays in place, just unreachable.voteOnProposal.ts/submitGovernanceAction.ts— the Azorius vote handler, execute ABI, and theircase DaoIdEnum.SHUbranches are commented out, so uncommenting restores them verbatim.ProposalHeader.tsx/ProposalSection.tsx— theisShuchecks compare against the raw"SHU"string (they takedaoId: string), keeping the queue/execute logic intact.useCalldataReview.ts— SHU entry commented out of the dao-proposals repo map.DaoOverviewHeader.tsx— drops the SHU-only 4-decimal price formatting.shared/dao-config/shu.tsand its registration stay, matching howOPis kept inrawDaoConfigByDaoIdwith its enum member commented.Verification
tsc --noEmitclean ·eslint0 errors · 527 tests / 54 suites pass.🤖 Generated with Claude Code