feat(dashboard): show every monitored DAO on the panel - #2125
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 44010372d1
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
🎨 UI Review
No findings — this is a clean, minimal wrapper fix. Validated against Figma — no change needed
MobileNo behavior change on mobile — Generated by Claude Code |
🎨 UI Review
Table scrollNo visual surface changes here — this is a wrapper/layout fix (drops Findings: 0 — no issues found. Generated by Claude Code |
🎨 UI Review
Panel — Monitored DAOs tableThis PR doesn't touch Validated against Figma — no change needed
Note
Generated by Claude Code |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 56f36d593b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7968dd9f4b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
The v2.1 panel is a scrolling page, not a single viewport: drop the table's fillHeight and the min-h-0/flex-1 chain that made it scroll inside the section, and let main scroll on desktop the way it already does on mobile. The table itself is untouched — same columns, tooltips, and sorting. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The short-viewport check still waited for the table container to overflow its own box, which was true only while the table was pinned to the viewport height. Now that the wrapper is unconstrained the container is exactly as tall as its rows, so that poll could never come back true and the Dashboard E2E job would have failed on the new, intended behaviour. It now checks the opposite: the table lays out past the fold and `main` is the element that scrolls. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The panel table container stops being a scrollport on desktop (containerClassName escape hatch on the DS Table), so the sticky header resolves against main, the page scroller. Mobile keeps the inner horizontal scroll: the header never pinned there and HeaderMobile is fixed with no specified offset to pin under. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Measured at 1024px the table runs 58px wider than its container, so lg:overflow-visible leaked a page-level horizontal scrollbar in the 1024-1279px band; the inner scrollport stays below xl. The pin test now stubs the session like its sibling, re-scrolls on every poll tick since metric cells stream in and grow the page, and measures the header in the same evaluation as its precondition. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…p range Column headers wrap between lg and xl, removing the 58px table overflow that forced the pin to xl, so the container can stop being a scrollport from lg up. The pin e2e test now runs at 1024px and 1920px and asserts main gains no horizontal overflow. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
a53c9c7 to
0742acc
Compare
|
Superseded by #2137, which combines the whole panel v2.1 stack into a single PR against dev. |
2 participants
Part 3/6 of the Panel v2.1 stack (DEV-1148). Base:
feat/panel-v2.1-ticker(#2124).What changes
Section 3 of the spec: the table itself is untouched — same columns, tooltips, sorting. Only the wrapper changes, so all rows show instead of scrolling inside a fixed-height viewport:
PanelTable.tsx— dropfillHeight, keepmin-h-[400px]so empty/loading states don't collapse.PanelSection.tsx— drop thelg:min-h-0/lg:flex-1/h-fullchain that constrained the section.app/page.tsx—mainnow scrolls at every breakpoint (it already did on mobile); the outerh-screen overflow-hiddenstays so the sidebar remains fixed.This is what makes room for the sections in parts 4–6; without it they'd be trapped below a locked viewport.
Verification
tsc --noEmitclean ·eslintclean · 527 tests / 54 suites pass · rendered locally at 1440px — all 12 DAOs visible, no inner scrollbar, page scrolls as one.