Merged
Conversation
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
Kiran01bm
reviewed
Apr 13, 2026
Contributor
|
also worth updating the |
revied
force-pushed
the
feature/opensearch-resource-type
branch
from
8f11445 to
60b96bb
Compare
Contributor
Author
|
Done — updated the Supported Resources section in README.md (ElastiCache and OpenSearch moved from "Easily extensible to" into "Currently implemented"). Also updated ARCHITECTURE.md to mark both as ✅ and added opensearch.go, helpers.go, and the opensearch detector to the repo structure diagram. |
Kiran01bm
previously approved these changes
Apr 15, 2026
revied
force-pushed
the
feature/opensearch-resource-type
branch
2 times, most recently
from
611d7fc to
6efe234
Compare
- Add opensearch entry to config/resources.yaml with pipe-delimited native_type_pattern for both flat and DB_SERVER Wiz report schemas - Add pipe-delimited pattern matching in matchesNativeTypePattern - Add column alias system in helpers.go for cross-schema compatibility (DB_SERVER.externalId → externalId, subscriptionExternalId → cloudAccount.externalId, etc.) - Add OpenSearch version normalization (strip OpenSearch_/Elasticsearch_ prefixes) - Add legacy Elasticsearch detection (versions 5.x/6.x/7.x → elasticsearch engine) - Add opensearch and elasticsearch to EOL ProductMapping - Add opensearch to orchestrator default resource types - Add observability logging in parseWizReport (row counts, filter stats) - Update README.md and ARCHITECTURE.md to reflect production-tested status Amp-Thread-ID: https://ampcode.com/threads/T-019d98f0-cc82-75bf-b664-e3a63eef6ee9 Co-authored-by: Amp <amp@ampcode.com>
bakayolo
force-pushed
the
feature/opensearch-resource-type
branch
from
782d6a9 to
144183c
Compare
- Map cloudAccount.externalId alias to cloudPlatform (DB_SERVER schema) - Make accountID non-required (graceful fallback for schemas without it) Tested: 290 OpenSearch findings processed successfully from DB_SERVER schema report. Amp-Thread-ID: https://ampcode.com/threads/T-019d98f0-cc82-75bf-b664-e3a63eef6ee9 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019d98f0-cc82-75bf-b664-e3a63eef6ee9 Co-authored-by: Amp <amp@ampcode.com>
bakayolo
previously approved these changes
Apr 17, 2026
Amp-Thread-ID: https://ampcode.com/threads/T-019d98f0-cc82-75bf-b664-e3a63eef6ee9 Co-authored-by: Amp <amp@ampcode.com>
bakayolo
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
convertCycleto correctly handle two-tier lifecycle (standard support -> extended support -> EOL) for products like OpenSearch and EKSChanges
EOL Provider (
pkg/eol/endoflife/)opensearch->amazon-opensearchProductMappingOpenSearch_prefix, truncate to major.minorconvertCycle: versions pasteolbut beforeextendedSupportare now correctly classified as extended support (YELLOW) instead of EOL (RED)Wiz Inventory Source (
pkg/inventory/wiz/opensearch.go)OpenSearch_2.11->2.11)Detector (
pkg/detector/opensearch/)Server Wiring (
cmd/server/main.go)WIZ_OPENSEARCH_REPORT_IDenv varTest plan
go build ./...passesgo test ./...passes (53+ tests including 13 new OpenSearch tests)OpenSearch_2.11,2.11.0,2.11formats🤖 Generated with Claude Code