fix: ensure the configured fan is correctly monitored#5
Open
ressu wants to merge 1 commit into
Open
Conversation
The previous fan lookup logic incorrectly always retrieved the generic `[fan]` object instead of the fan specified in the configuration. This resulted in the plugin monitoring the wrong device. The lookup now uses the full fan section string to accurately identify and fetch the correct fan object. This ensures the intended device is monitored and provides clearer error handling if the fan is not found.
Author
|
considering that PRs haven't been merged for over a year, mentioning @mut3xx just in case they just haven't noticed. Otherwise I'll just fork the project with the various fixes from this repo. |
ressu
added a commit
to ressu/klipper-filter_monitor
that referenced
this pull request
Feb 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous fan lookup logic incorrectly always retrieved the generic
[fan]object instead of the fan specified in the configuration. This resulted in the plugin monitoring the wrong device.The lookup now uses the full fan section string to accurately identify and fetch the correct fan object. This ensures the intended device is monitored and provides clearer error handling if the fan is not found.