feat(calculators): garnet fe_basis + wt fractionation - #10
Merged
Conversation
…-aware extraction to pt_grid
bknight1
added
feature
This was referenced Aug 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MAGEMinGarnetCalculator.__init__takesfe_basisargument ('FeOt'default,'Fe2+'for stoichiometric ferrous-only split)._extract_garnet_elements_from_oxidesbranches onself.fe_basis— FeOt places all iron on the divalent site (community convention); Fe2+ uses the excess-oxygen split.PhaseFunctions.fractionate_phasehandlesPP_vecindexing, addsfrac_amount <= 0no-op guard.gt_along_pathdocumentsnormalise_startsemantics;generate_2D_grid_gt_endmembersunwraps single-instance bundles.Depends on: #9 (refactor/instance-aware-extract-grid) + #8 (feat/utils-feot-redox)
Test plan
python3 -m unittest tests/test_fe_basis.py tests/test_fractionation.py(10 tests pass)python3 -m unittest discover tests(12 tests pass, 0 failures)