doc: Updated notes on how to contribute to Bitcoin Knots. - #314
Conversation
Retropex
left a comment
Retropex
left a comment
There was a problem hiding this comment.
ACK afcc758fd375def1604e8afc4493fd09d14bf1fd
|
For full consistency with the comms-channel update in this PR (IRC + mailing list -> Discord), several later references still point contributors to IRC and the mailing list, which Knots no longer uses:
Suggest updating these to Discord (and dropping "mailing list") so the whole document points to the same channel. |
|
Thank you for your feedback. I have replaced the IRC references with Discord. |
There was a problem hiding this comment.
Pull request overview
Updates CONTRIBUTING.md to better reflect current Bitcoin Knots contribution and communication practices, replacing outdated Bitcoin Core references and removing guidance that no longer applies to this repository.
Changes:
- Replaces several “Bitcoin Core” references/links with “Bitcoin Knots” equivalents (including issue links and translation process link).
- Updates contributor communication guidance to point to the Bitcoin Knots Discord.
- Simplifies repository guidance and adjusts the rebasing instructions.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Where a patch set proposes to change the Bitcoin consensus, it must have been | ||
| discussed extensively on the mailing list and IRC, be accompanied by a widely | ||
| discussed extensively on Discord, be accompanied by a widely | ||
| discussed BIP and have a generally widely perceived technical consensus of being |
There was a problem hiding this comment.
I lack the knowledge to update the documentation around a consensus change. It is such a large subject. BIP110 has challenged my own internal thoughts around how a consensus change should and could be made.
Generally, you would hope a consensus-level change would involve the users of Bitcoin and the developers of multiple node software implementations, each discussing the change using their own preferences, which could involve Discord groups, mailing lists, YouTube "shows", X, social media in general, etc.
This is more of an essay topic.
Can you chat with a CoPilot reviewer and get feedback, or is it only one way?
There was a problem hiding this comment.
These reviews seem to be one-way.
|
ACK |
287a85c to
27b2fbf
Compare
The current documentation on how to contribute to Bitcoin Knots contains outdated and incorrect information. This makes it difficult for new contributors to assist, as it leads them in directions away from what is required.
I have updated the documentation regarding current communication methods, fixed many links that pointed to Bitcoin Core instead of Bitcoin Knots, and removed irrelevant documentation.