Repository navigation
Conversation
decode() accepted 0xfd 0x01 0x00 as 1. A longer tag must not encode a value that fits in a shorter tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
decode()accepted a longer tag for a value that fits in a shorter one.fd0100,fe01000000, andff0100000000000000all decoded as1. Bitcoin CompactSize rejects that. A0xfdvalue must be at least0xfd, a0xfevalue must be greater than0xffff, and a0xffvalue must be greater than0xffffffff.Test plan
{ numberValue: 1, bytes: 3|5|9 }non-minimal encodingnpx tape test/*.js(92 tests OK), including the existing minimal vectors such asfdfd00Made with Cursor