feat(dataset): admit omitted-parent failures and height 474294 - #4
Closed
deadmanoz wants to merge 3 commits into
Closed
feat(dataset): admit omitted-parent failures and height 474294#4deadmanoz wants to merge 3 commits into
deadmanoz wants to merge 3 commits into
Conversation
The in-block forward-spend checker cannot see a parent that confirmed only in a competing same-height block. Add that evidence rule and the 1Hash body so ConnectBlock's missing-or-spent failure is re-derivable.
…loader Keep two confirmation requests in flight and stop once a proving parent is found.
Treat parent_kind as a reviewed claim, not a provider check.
deadmanoz
added a commit
to deadmanoz/stale-blocks
that referenced
this pull request
Sep 11, 2026
1Hash block 00000000000000000182acdf5657c93a0769dc6f9004047496b2e15efc6a4232 spends an output whose parent confirmed only in the same-height competitor. That is bad-txns-inputs-missingorspent at connect time, not an in-block ordering error. The replacement record and binary are in bitcoin-data/invalid-blocks#4. Point the README at the companion repository rather than the pre-474294 tree snapshot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bad-txns-inputs-missingorspentcase from an in-block forward spend.00000000000000000182acdf5657c93a0769dc6f9004047496b2e15efc6a4232). Transaction 110 spendsb11a78c6…:1; that parent is not in the body and confirmed in the same-height main-chain competitor. The.binmatches the copy previously stored in stale-blocks.parent_kindas a reviewedcanonicalclaim rather than a provider lookup.Test plan
python ci/sanity-check.py --fetch-prevouts(47 records, 6 block files)python -m unittest discover -s ci -p 'test_*.py'.cache/prevouts/; Esplora status andbtc-01both show confirmation at 474294 in000000000000000000db2504327e272fe7658fac0dd0741f46b212256e500886btc-01: stale and winner share canonical parent…e0084b3a; winner contains parent at index 809 and childa6655ca4…at 810Companion removal: bitcoin-data/stale-blocks#139