Per-pool share-warning toggle and aggregate large coinbase outputs - #1678
Per-pool share-warning toggle and aggregate large coinbase outputs#1678warioishere wants to merge 1 commit into
Conversation
|
Screenshots please 🙂 |
5769271 to
b5777d1
Compare
|
By having 2 separate max_item values the aggregation code is duplicated between frontend and backend. It's probably simpler to just keep it to the backend, at least for now. A cherry-on-top change would be to adjust the number of visible items on the frontend based on the size of the card, but that would be outside the scope of this PR. |
|
you are right, MAX_COINBASE_TX_OUTPUTS ist the single soure now. |
|
Can you fix conflicts, please? |
The warning is a field on PoolConfig, so it applies to every configured pool rather than just primary/fallback. Outputs beyond the array capacity are folded into coinbaseOthersCount/coinbaseOthersValueSatoshis; the user's own output is always kept. The coinbase-to-global-state block that the SV1 and SV2 tasks each carried is now the shared SYSTEM_update_coinbase_outputs.
7b1d73f to
54420fb
Compare
|
conflicts fixed. hope its okay like that. reimplemented on top of the current |


I'm working on new minings modes for blitzpool (currently in testing) that pays miners directly via the coinbase tx — Group-Solo / PPLNS, with the share going straight to each miner's address instead of accumulating at the pool. Ocean is the only other pool I'm aware of that splits the reward across many outputs the same way. PPLNS is not the real intention to her but the Group-Solo Mode might be interessting for some group Pleb Miners that dont want to trust a single admin or a pair of admins managing a multisig wallet.
Two things break on the Bitaxe dashboard when mining on a pool like that:
This PR addresses both. Defaults are unchanged for normal solo / fee-based pools.
Share warning toggle
/api/system/infoasstratumShareWarning/fallbackStratumShareWarning.true, so existing users see no change.NOT_SOLO_MINING/NO_MINING_REWARDmessages now check the active pool (primary vs fallback) and only fire if its toggle is on.Larger output list with smart fill
MAX_COINBASE_TX_OUTPUTSraised from 6 to 32.coinbaseOthersCount+coinbaseOthersValueSatoshis). OP_RETURN / witness commitment outputs are never evicted.Dashboard changes
+ N other recipient(s)summary line with the aggregated value. Includes outputs that fit in the array but didn't make the visible cap, plus any server-side overflow fromcoinbaseOthersCount.Things I'm happy to change if you want it different
GlobalState.Builds fine.