MAINT: remove old environment variables#1100
Open
ColmTalbot wants to merge 2 commits into
Open
Conversation
mj-will
approved these changes
Jun 25, 2026
GregoryAshton
left a comment
GregoryAshton
left a comment
Collaborator
There was a problem hiding this comment.
I think I am understanding that BILBY_ALLOW_PARAMETERS_AS_STATE is in fact deprecated anyway. And this also removes BILBY_INCORRECT_PSD_NORMALIZATION
So this looks good to me. However, we should update the changelog to state these are no longer accessible. Do we do that in this MR or separately?
Collaborator
|
+1 on including a CHANGELOG entry---looks good to me otherwise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1088