fix(gemini): strip Google model prefix - #979
Conversation
|
I reproduced the model-prefix behavior from #975 locally and compared the merge-base ( On the merge-base, I also checked the surrounding non-regression cases: an already-bare Gemini model stays bare, OpenCode still maps The ACP test suite passed on my setup ( Everything behaved as expected in the offline path I tested. I didn't run a live Gemini CLI call because I don't have a |
|
Thanks @Galius5136! I found other gemini issues as well, so I'd probably update on this thread. |
|
I have Gemini API credit available, so I picked up the piece @Galius5136 Setup: merge-base The fix works for the reported case:
One gap. The guard here is
Bare Worth noting the two PRs are not in conflict: applying this PR's Separately, All of the above is end-to-end validation against the live Gemini API rather |
Summary
Normalizes
google/gemini-*to the bare Gemini model ID only when configuring the Gemini ACP agent.Root cause
Gemini CLI expects a bare model name. BenchFlow retained the models.dev
google/prefix, causing Gemini CLI to construct an invalidmodels/google/gemini-*path.Impact
Provider-qualified Gemini model IDs work with the Gemini ACP agent; provider/model agents retain their existing prefix behavior.
Validation
uv run python -m pytest tests/test_acp.py -k 'TestConnectAcpModelSelection'uv run ruff check src/benchflow/acp/runtime.py tests/test_acp.pygit diff --checkFixes #975.