Skip to content

fix(gemini): trust ACP workspace - #70

Merged
bingran-you merged 1 commit into
mainfrom
bry/sync-gemini-skip-trust
Sep 2, 2026
Merged

fix(gemini): trust ACP workspace#70
bingran-you merged 1 commit into
mainfrom
bry/sync-gemini-skip-trust

Conversation

@bingran-you

@bingran-you bingran-you commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

Summary

Why

Gemini CLI otherwise prompts for workspace trust in a fresh benchmark sandbox and never starts its ACP server. BenchFlow core now includes the flag, so the manifest parity gate correctly rejects the old command.

Validation

  • cd contract && uv run --with pytest --with jsonschema env PYTHONPATH=. pytest -q (22 passed)
  • manifest-file pre-commit checks passed: large-file, case-conflict, merge-conflict, line-ending, private-key, trailing-whitespace, and typos
  • full pre-commit bootstrap is blocked before file execution by the repository Prettier environment trying to install a local Git dependency while npm allow-git policy rejects it; this TOML-only change is outside Prettier

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-02T08:49:29.932454Z d7b1e90 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@bingran-you
bingran-you merged commit af39feb into main Sep 2, 2026
2 checks passed
@bingran-you
bingran-you deleted the bry/sync-gemini-skip-trust branch September 2, 2026 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant