fix(codex-acp): reconcile the npm pin with benchflow core (1.6.0) - #66
Merged
bingran-you merged 1 commit intoAug 27, 2026
Merged
Conversation
benchflow's registry.AGENTS moved codex-acp to @agentclientprotocol/ codex-acp@1.6.0 in benchflow-ai/benchflow#1044; this manifest still installed 0.0.45, so benchflow's manifest-parity workflow has failed on every run since (main runs 62cc7e41, 656ec915, fbababf6, and every PR). One-field reconciliation of install_cmd; no other change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DZggU3vNYzr3hfDZJUE7jX
5 tasks
bingran-you
approved these changes
Aug 27, 2026
bingran-you
left a comment
bingran-you
left a comment
Collaborator
There was a problem hiding this comment.
Validated against BenchFlow main: agents contract tests 22/22, BenchFlow manifest parity 12/12, diff check and all applicable pre-commit hooks pass. This is the minimal one-field reconciliation for the live-validated codex-acp 1.6.0 upgrade from benchflow#1044.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
benchflow's
registry.AGENTSmoved codex-acp to@agentclientprotocol/codex-acp@1.6.0in benchflow#1044; this repo'sacp/codex-acp/manifest.tomlstill installs0.0.45. Because the two are compared field-by-field, benchflow'smanifest-parityworkflow has failed on every run since — onmainitself (62cc7e41,656ec915,fbababf6) and on every PR (e.g. benchflow#1046, where I hit it).One-field reconciliation of
install_cmd(0.0.45→1.6.0); no other change — byte-identical to core's currentAgentConfigfor the drifted field.Test plan
grep -c 'codex-acp@1.6.0' acp/codex-acp/manifest.toml→ 1; no0.0.45remains anywhere in the reporegistry.AGENTS['codex-acp'].install_cmdverbatim (the parity failure's own per-field diff shows the two strings differ only in this version)