Skip to content

enable tidy require all#60

Open
mtimaN wants to merge 1 commit intobemanproject:mainfrom
mtimaN:enable-tidy-require-all
Open

enable tidy require all#60
mtimaN wants to merge 1 commit intobemanproject:mainfrom
mtimaN:enable-tidy-require-all

Conversation

@mtimaN
Copy link
Copy Markdown
Contributor

@mtimaN mtimaN commented Apr 25, 2026

Issue: bemanproject/beman-tidy#260
This PR adds the following flags to the beman-tidy run: [".", "--verbose", "--require-all"].

In order for it to pass I added a placeholder link for the paper (beman-tidy requires a wg21 paper URL).

@mtimaN mtimaN marked this pull request as ready for review April 25, 2026 11:36
@mtimaN mtimaN changed the title enable tidy require all and add placeholder implements link enable tidy require all Apr 25, 2026
@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 100.0%. remained the same — mtimaN:enable-tidy-require-all into bemanproject:main

Copy link
Copy Markdown
Member

@neatudarius neatudarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think we should do this.

Commented more on bemanproject/beman-tidy#260 (comment)

@JeffGarland
Copy link
Copy Markdown
Member

In order for it to pass I added a placeholder link for the paper (beman-tidy requires a wg21 paper URL).

The paper number is assigned but has not yet been published -- the work in progress is in the repo under papers, that should be sufficient to pass the check.

@neatudarius
Copy link
Copy Markdown
Member

In order for it to pass I added a placeholder link for the paper (beman-tidy requires a wg21 paper URL).

The paper number is assigned but has not yet been published -- the work in progress is in the repo under papers, that should be sufficient to pass the check.

Yes, please take a look at the diff
image

He put https://wg21.link/P3610R0 (which is the good URL, with your reserved 3610 number). He wanted to say that currently the URL gives you 404 Not Found, which is expected.

Can we proceed with this PR?

@JeffGarland
Copy link
Copy Markdown
Member

JeffGarland commented Apr 25, 2026

I'd really rather not have a broken link in the site -- can we not just link back to the repo? I'm guessing that won't work bc it needs to point at wg21?

@neatudarius
Copy link
Copy Markdown
Member

I'd really rather not have a broken link in the site -- can we not just link back to the repo? I'm guessing that won't work bc it needs to point at wg21?

It does not work as per current beman-tidy implementation (which I think it's OK).

We can then disable this check after bemanproject/beman-tidy#279 is done.

But more important, we need codeowner input on bemanproject/beman-tidy#260 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants