Skip to content

fix(env-vars): fix env vars for message#9

Open
duratm wants to merge 1 commit into
mainfrom
fix/docker-compose-message-env-vars
Open

fix(env-vars): fix env vars for message#9
duratm wants to merge 1 commit into
mainfrom
fix/docker-compose-message-env-vars

Conversation

@duratm

@duratm duratm commented Jan 24, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores

    • Updated dependencies for multiple internal components.
  • Configuration

    • Added Spicedb integration support to the message service, introducing new configurable environment variables to manage external authorization system endpoint connectivity and security token credentials.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai

coderabbitai Bot commented Jan 24, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

This PR updates three submodule references (client, communities, and message) to new commits and adds SpiceDB configuration environment variables (SPICEDB_ENDPOINT and SPICEDB_TOKEN) to the message-api service in the docker-compose configuration.

Changes

Cohort / File(s) Summary
Submodule Updates
client, communities, message
Updated submodule pointers to new commits across three modules; no functional code changes or control flow modifications
Docker Compose Configuration
docker-compose.yaml
Added two new environment variables to message-api service: SPICEDB_ENDPOINT (default: http://spicedb:50051) and SPICEDB_TOKEN (default: foobar) for explicit Spicedb configuration

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

Suggested reviewers

  • Nayrode

Poem

🐰 Submodules hop to newer ground,
SpiceDB tokens spin around,
Docker's compose now whispers clear—
Three thumps of change, all crystal here! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'fix(env-vars): fix env vars for message' is vague and redundant—it repeats 'fix' twice and uses the generic term 'env vars' without clarifying which specific variables or what issue is being addressed. Consider a more specific title like 'fix: add SPICEDB environment variables to message service configuration' to clearly communicate the main change.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@message`:
- Line 1: There is a typo in the environment variable name: replace
SPICEDB_ENPOINT with the correct SPICEDB_ENDPOINT in docker-compose.yaml (the
variable referenced around the block that sets service environment variables),
ensuring it matches .env.example and all usages so services receive the intended
configuration value.
🧹 Nitpick comments (1)
docker-compose.yaml (1)

352-354: Pre-existing typo in communities-api SpiceDB config.

Not introduced by this PR, but line 353 has SPICEDB_ENPOINT (missing 'D') which appears to be a typo. Line 352 has the correct SPICEDB_ENDPOINT. This duplicate with typo may cause confusion or issues if the application reads the wrong variable name.

Suggested fix (outside this PR's scope)
       SPICEDB_ENDPOINT: ${SPICEDB_ENDPOINT:-http://spicedb:50051}
-      SPICEDB_ENPOINT: ${SPICEDB_ENDPOINT:-http://spicedb:50051}
       SPICEDB_TOKEN: ${SPICEDB_TOKEN:-foobar}

Comment thread message
@@ -1 +1 @@
Subproject commit e166f74643fc0b67a175a1436c30f086605b2ce7
Subproject commit ce577475bf3fafdf321c83afd58190a36c186773

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Check repository structure and submodule status

echo "=== Repository root files ==="
ls -la

echo -e "\n=== Check for .gitmodules ==="
if [ -f .gitmodules ]; then
  cat .gitmodules
else
  echo ".gitmodules not found"
fi

echo -e "\n=== Check git status ==="
git status --short

echo -e "\n=== Look for docker-compose.yaml ==="
find . -name "docker-compose.yaml" -o -name "docker-compose.yml" 2>/dev/null | head -20

echo -e "\n=== Check if message directory exists ==="
if [ -d message ]; then
  echo "message directory exists"
  ls -la message/
else
  echo "message directory does not exist"
fi

Repository: beep-industries/central

Length of output: 1872


🏁 Script executed:

#!/bin/bash
# Check docker-compose.yaml content and PR changes

echo "=== Check docker-compose.yaml for SPICEDB vars ==="
grep -n "SPICEDB" docker-compose.yaml || echo "No SPICEDB variables found"

echo -e "\n=== Check git log for recent commits ==="
git log --oneline -10

echo -e "\n=== Get the HEAD commit hash and show its changes ==="
CURRENT_HEAD=$(git rev-parse HEAD)
echo "Current HEAD: $CURRENT_HEAD"
git show --stat HEAD

echo -e "\n=== Show full diff for HEAD commit ==="
git show HEAD --no-stat

Repository: beep-industries/central

Length of output: 1456


🏁 Script executed:

#!/bin/bash
# Get the full diff for the HEAD commit

echo "=== Full commit diff (first 200 lines) ==="
git show HEAD | head -200

echo -e "\n=== Extract docker-compose.yaml changes ==="
git show HEAD -- docker-compose.yaml | grep -A 5 -B 5 "SPICEDB_ENDPOINT\|SPICEDB_TOKEN" | head -50

Repository: beep-industries/central

Length of output: 8414


Fix typo in docker-compose.yaml: SPICEDB_ENPOINT should be SPICEDB_ENDPOINT.

Line 353 in docker-compose.yaml defines an environment variable with a typo: SPICEDB_ENPOINT (missing the 'D'). This should be SPICEDB_ENDPOINT to match the correct variable name used elsewhere in the file and in .env.example. Services relying on this environment variable may not receive the expected configuration value.

🤖 Prompt for AI Agents
In `@message` at line 1, There is a typo in the environment variable name: replace
SPICEDB_ENPOINT with the correct SPICEDB_ENDPOINT in docker-compose.yaml (the
variable referenced around the block that sets service environment variables),
ensuring it matches .env.example and all usages so services receive the intended
configuration value.

@Nayrode Nayrode left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty boss, lgtm

@Courtcircuits

Copy link
Copy Markdown
Contributor

Pls fix your conflicts. I Created a branch that fix them if you want : fix/docker-compose-msg-vars-conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants