market: fetch chart bytes from the v2 appstore route - #3958
Draft
pengpeng wants to merge 1 commit into
Draft
Conversation
API_CHART_PATH is the last v1 path market still asks its source for; the
four sync paths beside it moved to /api/v2 already. The v1 and v2 chart
routes are answered by one handler upstream, so this changes the spelling
and nothing about the response.
Ordering: the cluster's Appstore API has to serve
/api/v2/applications/{name}/chart before this lands, otherwise every chart
download 404s. Reverting the value restores the v1 route on its own.
API_HASH_PATH, API_DATA_PATH and API_DETAIL_PATH are left as they are:
no market code reads them, and deleting them belongs in a change that is
about them rather than about the chart route.
Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
pengpeng
marked this pull request as draft
August 15, 2026 14:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
API_CHART_PATHis the last v1 path market still asks its source for. The foursync paths beside it (
API_CATALOG_PATH,API_TAXONOMY_PATH,API_APPLICATIONS_PATH,API_BROWSE_PATH) moved to/api/v2some time ago;this one did not.
One line in
framework/market/.olares/config/cluster/deploy/market_deploy.yaml:The v1 and v2 chart routes are answered by the same handler upstream, so this
changes the spelling of the request and nothing about the response.
Nothing has to be sequenced against this
beclab/marketPR #414 gives the chart download a fallback: a source thatanswers 404 on the configured path is asked for the same route under the other
prefix, in either direction. So this line now decides which prefix is tried
first, not whether charts can be downloaded at all.
The one requirement is that the market image deployed by this manifest contains
that fallback — otherwise a v2-only request against a v1-only remote fails, which
is what today's remotes still are:
400 means the route exists and rejected the missing
versionargument; 404 meansthere is no route.
Reverting is this one line back to
/api/v1/...; no code rollback is involved.Left alone on purpose
API_HASH_PATH,API_DATA_PATHandAPI_DETAIL_PATHa few lines above namevariables no market code reads — leftovers from the v1 syncer. Removing them is
worth doing, in a change that is about them rather than about the chart route.