Skip to content

Turn on revive linter in golangci config #442

Description

@carreter

Describe the desired feature/enhancement

Seems like golangci dropped support for golint a few versions ago. IMO, we should definitely have some sort of linting enabled!

Is your feature request related to a problem?

The problem: I cannot stand unlinted codebases!

Describe the solution you'd like

Add revive, a drop-in replacement for golint, to the list of enabled linters .golangci.yml.

This will require going through the entire codebase and fixing all of the errors until just lint is happy. Running golangci-lint -c .golangci.yml run --fix will take you part of the way there. It would probably also be good to add another entry to the justfile called lint-fix that runs golangci-lint -c .golangci.yml run --fix, or allow the user to pass additional arguments to the lint target (e.g. just lint --fix).

Describe alternatives you've considered (optional)

We could just leave the linter off, but that would make me sad :(

Additional context

Add any other context or screenshots about the feature request here.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    devopsImprovements to DevOps (e.g. GitHub actions, linting, etc.)enhancementNew feature or requestgood first issueGood for newcomershelp wantedExtra attention is neededlow priorityWould be nice to fix, but doesn't have to happen right now/there are more important thingsstale

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions