Skip to content

AzureIDIR (IDIR MFA) support#250

Merged
TimCsaky merged 1 commit into
masterfrom
feature/azureidir
Jun 11, 2026
Merged

AzureIDIR (IDIR MFA) support#250
TimCsaky merged 1 commit into
masterfrom
feature/azureidir

Conversation

@norrisng-bc

@norrisng-bc norrisng-bc commented May 27, 2026

Copy link
Copy Markdown
Member

Description

This PR introduces full support for IDIR MFA (a.k.a. azureidir) as an identity provider, alongside the existing SiteMinder IDIR (or idir).

Partial support was already available in the local dev environment, but behaviour was buggy. Some examples of this include:

  • A user logging in via IDIR MFA wouldn't be treated as an elevated user (resulting in a slightly restricted feature set)
  • Permissions assigned to an idir user didn't carry over to the azureidir-equivalent user
  • And despite this distinction, the BCBox UI didn't expose the underlying IDP, resulting in potential confusion (e.g. a user search returning multiple seemingly identical results)

Similar to the COMS-side changes made to enable IDIR MFA (bcgov/common-object-management-service#320), this was achieved by 'coercing' authStore.profile.identity_provider to idir whenever azureidir was present in the corresponding JWT field.

https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3713

Types of changes

New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

See also: bcgov/common-object-management-service#320

@github-actions

Copy link
Copy Markdown

Coverage Report (Application)

Totals Coverage
Statements: 70.67% ( 53 / 75 )
Methods: 62.5% ( 5 / 8 )
Lines: 81.63% ( 40 / 49 )
Branches: 44.44% ( 8 / 18 )

@github-actions

github-actions Bot commented May 27, 2026

Copy link
Copy Markdown

Coverage Report (Frontend)

Totals Coverage
Statements: 14.66% ( 869 / 5928 )
Methods: 14.94% ( 162 / 1084 )
Lines: 18.07% ( 575 / 3182 )
Branches: 7.94% ( 132 / 1662 )

Already enabled on local environment, but crucially, the corresponding idir/azureidir user is now treated as the same user (instead of completely different ones).
@TimCsaky TimCsaky merged commit 5093d91 into master Jun 11, 2026
17 of 18 checks passed
@norrisng-bc norrisng-bc deleted the feature/azureidir branch June 11, 2026 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants