FIX: Linux startup crash when using Japanese or Korean - #12082
Merged
Conversation
tonghao-bbl
reviewed
Aug 31, 2026
| // Reparent(nullptr); | ||
| GetParent()->RemoveChild(this); | ||
| Label::initSysFont(app_config->get_language_code()); | ||
| Label::initSysFont(app_config->get_language_code(), false); |
Contributor
There was a problem hiding this comment.
why make the last parameter false
Contributor
Author
There was a problem hiding this comment.
At this point, the fonts have already been registered in BambuStudio.cpp:1607, so I removed the second call to wxFont::AddPrivateFont().
Contributor
|
LGTM @lanewei120 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a Linux startup crash when Bambu Studio is configured to use Japanese or Korean.
Root cause
GUI_Appis constructed beforewxEntry()initializes wxGTK.The constructor previously called the language-specific
Label::initSysFont(). On Linux, only the HarmonyOS fonts were registered as private fonts. When Japanese or Korean was selected, the requested font could be unavailable, causingLabel::sysFont()to fall back towxSystemSettings::GetFont().This fallback may access
GtkSettingsbefore GTK initialization, resulting in GLib/GTK critical errors and a startup crash.Changes
Source Han Sans JPandNanumGothicfonts withwxFont::AddPrivateFont()on Linux, alongside the existing HarmonyOS fonts.Labelfont initialization from theGUI_Appconstructor toon_init_inner(), afterwxEntry()has initialized wxGTK.Labelfonts need to be recreated.