fix(server): return JSON 404 for unknown /api/* routes instead of HTML#748
Open
buihongduc132 wants to merge 1 commit into
Open
fix(server): return JSON 404 for unknown /api/* routes instead of HTML#748buihongduc132 wants to merge 1 commit into
buihongduc132 wants to merge 1 commit into
Conversation
All three servers (plan, review, annotate) serve the SPA HTML for any unmatched route. This means hitting /api/nonexistent returns the full HTML page with 200 OK — confusing for API clients and wasteful. Now unknown /api/* paths get a proper JSON 404 response before the SPA fallback kicks in. Non-API paths (like /some/random/path) still serve HTML for SPA routing as before. Tested on all three server types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
All three servers (plan, review, annotate) serve the SPA HTML for any unmatched route. This means hitting
/api/nonexistentreturns the full HTML page with 200 OK — confusing for API clients, wasteful for bandwidth, and looks weird in logs.Why
Ran into this while working on remote client mode — the client would hit
/api/somethingwith a typo and get back a giant HTML blob instead of a clean error. Would be better if API paths fail fast with JSON.Changes
Added a 5-line guard in each server (
index.ts,annotate.ts,review.ts) right before the SPA fallback:Non-API paths (like
/some/random/path) still serve HTML for SPA routing — no change there.Testing