Use fzf to select a package if none supplied - #28
Open
gergesh wants to merge 1 commit into
Open
Conversation
Owner
|
why? |
Contributor
Author
|
Because sometimes you (read: I) don't remember the exact package name you'd like to pull and fuzzy searching for "Facebook" gets the job done the fastest |
|
i like the idea, but it would add potential interactivity to a static command -> using it in scripts might break functionality, so making it optional and hiding it behind an argument would probably be better |
Contributor
Author
|
The current implementation does not break anything, as it only changes behavior in the case where a package name wasn't supplied - not a valid condition currently. |
Owner
|
Sorry @gergesh, I personally don't like the idea of adding another dependency just to have a package name guessed. Lemme keep this thread here for a while, let's see what the community thinks about this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.